FIO-7507: Publish dev tag to npm #1060
Conversation
| @@ -17,7 +17,7 @@ export class FormioReportComponent extends FormioComponent implements OnInit, On | |||
| @Output() fetchDataError = new EventEmitter<any>(); | |||
| @ViewChild('report', { static: true }) declare formioElement?: ElementRef<any>; | |||
|
|
|||
| public isLoading: boolean; | |||
| // public isLoading: boolean; // Was not allowing yarn build | |||
There was a problem hiding this comment.
I'm not so certain about this change in the context of this ticket - I gather this causes a TypeScript error? If that's the case, how does this build ever succeed? This library is routinely built and published in our build pipelines
There was a problem hiding this comment.
Overlooked before committing. Retested, looks like it is possibly redundant and can be removed.
There was a problem hiding this comment.
I guess my issue is that "possibly redundant" is not enough evidence for me to clobber a class instance variable in a PR that is just trying to publish a dev tag to npm. If we're not absolutely certain, let's check with the author of the code (Tanya?), who may say "you can just add an initializer to the class" or "sure go ahead it's not necessary"
There was a problem hiding this comment.
FormioReportComponent extends FormioComponent which extends FormioBaseComponent which includes an isLoading property already, which I believe it where our redundancy is coming from.
FormioReportComponent (causes redundant error)
FormioBaseComponent
When running yarn build on commit where redundancy was added
Link to Jira Ticket
https://formio.atlassian.net/browse/FIO-7507
Description
What changed?
Added a publish job to push to a "dev" npm tag that includes a PR number and commit short hash as identifiers.
Comparison RC published code:
https://www.npmjs.com/package/@formio/angular/v/7.5.0-rc.1?activeTab=code
To compare aginst for DEV published code:
https://www.npmjs.com/package/@formio/angular/v/7.5.0-dev.1060.57ea833?activeTab=code
Why have you chosen this solution?
Retains a unique version for the commit and easily identifiable what commit the version belongs to.
Breaking Changes / Backwards Compatibility
n/a
Dependencies
n/a
How has this PR been tested?
https://github.com/formio/angular/actions/runs/8394115755
Checklist: