Upgrade ngx-bootstrap and other dependencies. #1087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
2 tasks
brendanbond
reviewed
Aug 1, 2024
| @@ -31,7 +31,7 @@ | |||
| "@formio/js": "^5.0.0-rc.54", | |||
| "zone.js": "~0.13.0 || ~0.14.0", | |||
| "lodash": "^4.17.20", | |||
| "ngx-bootstrap": "^10.0.0 || ^11.0.0 || ^12.0.0", | |||
| "ngx-bootstrap": "^10.0.0 || ^11.0.0 || ^12.0.0 || ^18.0.0", | |||
There was a problem hiding this comment.
Are versions 13 - 17 not supported here, or could we use the operator syntax, e.g. "nxg-boostrap": "<= 18.x"
There was a problem hiding this comment.
ngx-bootstrap just jumped straight from 12 to 18
https://www.npmjs.com/package/ngx-bootstrap?activeTab=versions
brendanbond
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Jira Ticket
https://formio.atlassian.net/browse/FIO-8749
Description
We are upgrading the dependencies of primarily ngx-bootstrap as well as other Angular dependencies.
Breaking Changes / Backwards Compatibility
Use this section to describe any potentially breaking changes this PR introduces or any effects this PR might have on backwards compatibility
Dependencies
Use this section to list any dependent changes/PRs in other Form.io modules
How has this PR been tested?
Use this section to describe how you tested your changes; if you haven't included automated tests, justify your reasoning
Checklist: