Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-8915: fixed an issue where errors list does not display in formmanager and formview pro #1092

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

TanyaGashtold
Copy link
Contributor

@TanyaGashtold TanyaGashtold commented Aug 27, 2024

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-8915

Description

What changed?

Before, in formiojs 4x branch, the showErrors method could accept a single error and add it to all form errors (this.errors). When the error is undefined, this method showed all other form errors any way. In formiojs 5.x this method expects the list of errors, if errors are empty, the method just removes the errors list. So, this PR changed the showErrors to call it with errors argument.

How has this PR been tested?

Manually

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@HannaKurban HannaKurban merged commit 8e4b1ee into master Aug 28, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants