Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-8354: fallback to passing response in argument if response.body is undefined #101

Merged
merged 2 commits into from
Jun 7, 2024

Conversation

ZenMasterJacob20011
Copy link
Contributor

@ZenMasterJacob20011 ZenMasterJacob20011 commented Jun 3, 2024

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-8354

Description

What changed?

Changed the events emitted by Formio to fallback to passing the response object to emit argument if response.body is undefined. This allows for clients using this api to handle these events based on the data in the response object.

I chose this solution because it allows for backwards compatibility by keeping response.body as a possible argument in the emit function

Breaking Changes / Backwards Compatibility

None

Dependencies

N/A

How has this PR been tested?

manually tested

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

Copy link
Contributor

@brendanbond brendanbond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why can't we write simple unit tests for this event emission?

@ZenMasterJacob20011
Copy link
Contributor Author

I'll start writing tests when I make changes

@brendanbond brendanbond merged commit 73c7c1e into master Jun 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants