Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update validate required recursion to not recurse when nested data type #102

Merged
merged 3 commits into from
Jun 4, 2024

Conversation

brendanbond
Copy link
Contributor

Link to Jira Ticket

n/a

Description

The validateRequired rule needs to recursively evaluate objects (like select boxes), but it should not recursively evaluate nested data types (such as data grids, edit grids, etc.).

Breaking Changes / Backwards Compatibility

n/a

Dependencies

n/a

How has this PR been tested?

I've added automated tests. (coming soon...)

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@lane-formio lane-formio merged commit d9af57a into master Jun 4, 2024
5 checks passed
lane-formio added a commit that referenced this pull request Jul 1, 2024
update validate required recursion to not recurse when nested data type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants