Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-8512: fixed an issue where conditionally visible data inside layout components inside editGrid/dataGrid is unset on server side #108

Conversation

TanyaGashtold
Copy link
Contributor

@TanyaGashtold TanyaGashtold commented Jun 26, 2024

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-8512

Description

What changed?

  • fixed an issue where compPath is not defined correctly inside getComponentActualValue, since layout components are considered for path calculation. Added logic that takes only closest input component for path calculation;
  • fixed an issue where wrong component is passed as an argument to getComponentActualValue inside checkSimpleConditional. Before the conditional component was passed together with path of the condition component, I have changed it to pass the condition component (that is on which the visibility of the component depends).

How has this PR been tested?

Manually + test added

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

…ut components inside editGrid/dataGrid is unset on server side
@brendanbond brendanbond merged commit 7b67d3e into master Jun 27, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants