Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix formiojs tests #145

Merged
merged 2 commits into from
Sep 10, 2024
Merged

chore: fix formiojs tests #145

merged 2 commits into from
Sep 10, 2024

Conversation

brendanbond
Copy link
Contributor

Link to Jira Ticket

n/a

Description

Since Day components emptyValue was changed to an empty string, validation is broken. This PR changes the isPartialDay method to return true on an empty value.

Additionally, some type guards were changed to handle undefined components.

Breaking Changes / Backwards Compatibility

n/a

Dependencies

n/a

How has this PR been tested?

n/a

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@TanyaGashtold TanyaGashtold merged commit 74d4170 into master Sep 10, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants