Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-9086: use for validation only dataFormat (data storage format) #160

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

Maria-Golomb
Copy link
Contributor

@Maria-Golomb Maria-Golomb commented Sep 30, 2024

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-9086

Description

Time component validation was changed as follows:
Server side and client side evaluations of validity use component dataFormat for validation.
For correct use on client side wad added changes on formio.js ( only this.dataValue is used for validation)
Those changes help avoid validation errors caused by mismatches between data display and storage format.

Dependencies

formio/formio.js#5834

manually,
autotests

Use this section to describe how you tested your changes; if you haven't included automated tests, justify your reasoning

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@brendanbond brendanbond merged commit cabaa43 into master Oct 15, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants