FIO-9244: fixed an issue where Radio component with Allow only available values checked does not submit #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ble values checked does not submit
brendanbond
requested changes
Oct 22, 2024
| @@ -249,7 +249,7 @@ export const validateAvailableItems: RuleFn = async (context: ValidationContext) | |||
| ? null | |||
| : error; | |||
| } | |||
| return values.find((optionValue) => optionValue === value) !== undefined ? null : error; | |||
There was a problem hiding this comment.
Does this cover the case of, like, custom values? Should we be doing a deep equal here instead? I want to make sure all of our bases are covered (i.e. custom values or JSON values of any shape)
There was a problem hiding this comment.
@brendanbond There is a check above this line for the object value, I'm pretty sure it should cover most of the json and custom values, so this line is only triggered for primitive ones. I changed it a bit to pass both validation in case if dataSrc=values and if values is an array of primitives. So all the bases seem to be covered, but we can further discuss this if you have any other adjustments in mind.
johnformio
approved these changes
Oct 22, 2024
…ble values checked
KatrinKhilko
force-pushed
the
FIO-9244-Radio-component-with-Allow-only-available-values-checked-does-not-submit
branch
from
f3525a9 to
dc79aaa
Compare
brendanbond
approved these changes
Oct 23, 2024
lane-formio
pushed a commit
that referenced
this pull request
Oct 23, 2024
…ow-only-available-values-checked-does-not-submit FIO-9244: fixed an issue where Radio component with Allow only available values checked does not submit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Jira Ticket
https://formio.atlassian.net/browse/FIO-9244
Description
Changed incorrect values for Radio Component.
Breaking Changes / Backwards Compatibility
n/a
Dependencies
n/a
How has this PR been tested?
tested manually, fixed incorrect values in existing test from #152
Checklist: