Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-9308: Fixed the paths with nested forms by ensuring we are always… #188

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

travist
Copy link
Member

@travist travist commented Nov 4, 2024

… dealing with the absolute paths with clearOnHide, conditions, filters, and validations.

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-9308
https://formio.atlassian.net/browse/FIO-9306

Description

There are many places within the core processors, where the "absolute" path is needed to determine which fields are modified via the conditionals, clear on hide, etc. The problem is with Nested Forms, the "path" is relative and is not absolute. To fix this issue, we need to make a call to "getAbsoluteComponentPath" which ensures we are dealing with the absolute paths when making these decisions.

Breaking Changes / Backwards Compatibility

None

Dependencies

None

How has this PR been tested?

Automated tests was written for the 9308 failure.

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

… dealing with the absolute paths with clearOnHide, conditions, filters, and validations.
Copy link
Contributor

@johnformio johnformio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@brendanbond brendanbond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brendanbond brendanbond merged commit 310d86d into master Nov 5, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants