Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO 7488: improve error handling #59

Merged
merged 8 commits into from
Apr 17, 2024
Merged

FIO 7488: improve error handling #59

merged 8 commits into from
Apr 17, 2024

Conversation

brendanbond
Copy link
Contributor

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-7488

Description

Replaces ValidatorError and DereferenceError with a more generic ProcessorError

Breaking Changes / Backwards Compatibility

n/a

Dependencies

n/a

How has this PR been tested?

n/a

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@@ -30,13 +30,13 @@ export const shouldValidate = (context: ValidationContext) => {

function validateValue(value: DataObject[any]): asserts value is Record<string, boolean> {
if (value == null || typeof value !== 'object') {
throw new ValidatorError(
throw new Error(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And here

@AlexeyNikipelau AlexeyNikipelau merged commit 2102073 into master Apr 17, 2024
3 checks passed
lane-formio pushed a commit that referenced this pull request May 14, 2024
FIO 7488: improve error handling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants