Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-8288: do not validate dates in textfield components with calendar widgets #90

Merged
merged 2 commits into from
May 21, 2024

Conversation

brendanbond
Copy link
Contributor

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-8288

Description

Previous versions of the Enterprise Server didn't validate textfield component (with calendar widget) date values. This PR updates the date validation rule to ignore textfield components with the calendar widget.

This kind of makes sense - it's almost as if by selecting the calendar widget on a textfield rather than a date/time component, you're opting into client-side manipulation only and the end result will be merely a string in the database (rather than, say, an ISO string that can easily be converted, parsed, etc.).

Breaking Changes / Backwards Compatibility

This unifies 9.x behavior with 8.x behavior.

Dependencies

n/a

How has this PR been tested?

I've updated the automated tests to reflect the new (old?) expected behavior, and existing formio and formio-server tests pass.

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@AlexeyNikipelau AlexeyNikipelau merged commit ab8cc84 into master May 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants