Fio-8316 invalid data submitted in nested form #94
Conversation
| @@ -13,7 +13,7 @@ | |||
| "./dist/formio.core.min.js": "./dist/formio.core.min.js" | |||
| }, | |||
| "scripts": { | |||
| "test": "TEST=1 mocha -r ts-node/register -r tsconfig-paths/register -r mock-local-storage -r jsdom-global/register -b -t 0 'src/**/__tests__/*.test.ts'", | |||
| "test": "TEST=1 nyc --reporter=lcov --reporter=text --reporter=text-summary mocha -r ts-node/register -r tsconfig-paths/register -r mock-local-storage -r jsdom-global/register -t 0 'src/**/__tests__/*.test.ts'", | |||
There was a problem hiding this comment.
This will run the test through the code coverage. It creates an HTML report to look at manually and file coverage and summary reports in the console.
I also removed the bail flag so all tests run. Not sure if that will cause and issue downstream or not.
| "src/experimental/**/*.ts", | ||
| "src/types/**/*.ts" | ||
| ], | ||
| "all": true | ||
| } |
There was a problem hiding this comment.
code coverage configuration. Some of the exclusions should be reviewed. the coverage thresholds are based on current value based on the entire project.
src/process/filter/index.ts
Outdated
| // excluding those from this and setting their components onto the submission directly | ||
| if (pathFilter.compModelType !== 'dataObject') { | ||
| set(filtered, path, value); | ||
| } else { |
There was a problem hiding this comment.
removing the logic to append the data object when the path is an object.
skipping dataObject model types. the child field are included in the scope.filter set, so they get processed and when they do it will set the data field correctly
|
@AlexeyNikipelau This change was from #78 PR. Please make sure I didn't break anything. All of the unit tests you added are still passing. |
There was a problem hiding this comment.
I ran this branch versus the tests on a stable version of formio-server, and the following test failed:
1) Project Tests
Nested Submissions
Should allow you to update a submission with sub-submissions.:
Uncaught AssertionError [ERR_ASSERTION]: The childA form was not submitted
+ expected - actual
-false
+true
Lmk if you'd like to discuss, I think this is a pretty tricky issue.
…n't get mutated during filter post process
@brendanbond I ran the test in server and this test did not fail, but a validation one did. I don't think that's related to this change though. |
* skipping dataObject model types when filtering * only skipping dataObject model types * integrated istanbul code coverage testing with current thresholds * removed console statements * using functional version of lodash set so original submit object doesn't get mutated during filter post process * verified dataGrid submissions are valid --------- Co-authored-by: John Teague <[email protected]>
* skipping dataObject model types when filtering * only skipping dataObject model types * integrated istanbul code coverage testing with current thresholds * removed console statements * using functional version of lodash set so original submit object doesn't get mutated during filter post process * verified dataGrid submissions are valid --------- Co-authored-by: John Teague <[email protected]>
Link to Jira Ticket
https://formio.atlassian.net/browse/FIO-8316
Description
What changed?
Some changes allowed data to be saved with the submission not defined on a nested form. The current implementation sets the entire
datafield in the submission if it is an object. The change to fix this was it skip the component if the model type isdataObject. Child components fordataObjectmodels are recursively added to the filter scope, allowing the child fields to be processed correctly.Code coverage was added with nyc / istanbul.js
Breaking Changes / Backwards Compatibility
No breaking changes
Dependencies
None
How has this PR been tested?
Unit tests in core.
I also linked this version to formio-server and ran the tests there. I had some breaking tests, but I don't think they are related to this change.
Checklist: