Merge pull request #5944 from formio/FIO-8862-fixed-unnecessary-redra…

…wings-of-value-component-in-conditional-ui FIO-8862: fixed unnecessary redrawings of the value component in conditional ui
formio · Dec 12, 2024 · 93df2b5 · 93df2b5
2 parents 74aadbb + 74e70b0
commit 93df2b5
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/src/components/editgrid/EditGrid.js b/src/components/editgrid/EditGrid.js
@@ -344,13 +344,16 @@ export default class EditGridComponent extends NestedArrayComponent {
 
   checkRowVariableTypeComponents(editRow, rowIndex) {
     const rowComponents = editRow.components;
+    let typeChanged = false;
 
     if (_.some(this.variableTypeComponentsIndexes, (compIndex) => {
       const variableTypeComp = rowComponents[compIndex];
       return variableTypeComp.type !== variableTypeComp.component.type;
     })) {
       editRow.components = this.createRowComponents(editRow.data, rowIndex, true);
+      typeChanged = true;
     }
+    return typeChanged;
   }
 
   setVariableTypeComponents() {
@@ -1121,8 +1124,10 @@ export default class EditGridComponent extends NestedArrayComponent {
         }
 
         if (this.variableTypeComponentsIndexes.length) {
-          this.checkRowVariableTypeComponents(editRow, rowIndex);
-          this.redraw();
+          const typeChanged = this.checkRowVariableTypeComponents(editRow, rowIndex);
+          if (typeChanged) {
+            this.redraw();
+          }
         }
       };