Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-7355 Fixed issue with HTML5 select flickering on initial click #5366

Merged
merged 2 commits into from
Nov 2, 2023

Conversation

antonSoftensity
Copy link
Contributor

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-7355

Description

Removed handler that called update() function for HTML5 select on focus, because there is no mechanisms to change Select options data after the element was already initialized, and any custom/url and other dynamic data gets set on init

How has this PR been tested?

Tested locally

image

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

Copy link
Contributor

@TanyaGashtold TanyaGashtold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am afraid that this may break select components (html5) with custom data source (e.g. if the options are calculated and depend on the values of other form component). Can you please check this use case.

@antonSoftensity
Copy link
Contributor Author

Good catch, I reworked the fix so that the values are updated when the Select data source is set to 'Custom' without unnecessary update on the first click

@TanyaGashtold TanyaGashtold merged commit 4f58085 into master Nov 2, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants