Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-3820: File synchronization feature #5367

Merged
merged 7 commits into from
Nov 28, 2023

Conversation

roma-formio
Copy link
Contributor

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-3820

Description

Reimplemented file component. Added file synchronization feature.

Dependencies

This PR depends on the following PRs from other Form.io modules:
formio/bootstrap#79
https://github.com/formio/formio-server/pull/1367

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@roma-formio
Copy link
Contributor Author

Need additional sync with this PR #5356. Will do it when this PR is merged into the master branch.

@roma-formio roma-formio changed the title [DO_NOT_MERGE] FIO-3820: File synchronization feature FIO-3820: File synchronization feature Nov 1, 2023
Copy link
Contributor

@brendanbond brendanbond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good, but tests are failing - can we get to the bottom of that?

@roma-formio
Copy link
Contributor Author

This looks pretty good, but tests are failing - can we get to the bottom of that?

Some tests depend on @formio/bootstrap changes for the file component. Tests should pass after pulling the newest version of @formio/bootstrap. Verified locally, updated @formio/bootstrap, ran updateRenders, and all tests passed.

@travist travist merged commit 99932a9 into master Nov 28, 2023
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants