Revert "Fio 7074 setting submission on wizard does not update data" #5385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #5351 as a result of Brendan's investigation below.
Brendan:
It looks to me like the Sasha's solution for FIO-7074 (#5351) and Hanna's solution for FIO-7351 (formio/formio#1634) are conflicting: when the submission reaches the server, we almost always pass the sanitize flag, which has been added to the insanely long conditional check that decides whether or not to call the
mergeData()method in Wizard'ssetValue()method. This results in mergeData() not being called, and the submission coming back mutated and saved to the database incorrectly.