FIO-7184 Fixed showing incorrect value for DateTime and Time componen… #5393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts with multiple value enabled inside of the DataTable
TanyaGashtold
requested changes
Nov 16, 2023
| @@ -203,6 +203,9 @@ export default class DateTimeComponent extends Input { | |||
| format += format.match(/z$/) ? '' : ' z'; | |||
| const timezone = this.timezone; | |||
| if (value && !this.attached && timezone) { | |||
| if (Array.isArray(value) && this.component.multiple) { | |||
| return value.map((item) => _.trim(FormioUtils.momentDate(item, format, timezone).format(format))).join(', '); | |||
| } | |||
| return _.trim(FormioUtils.momentDate(value, format, timezone).format(format)); | |||
| } | |||
| return (value ? _.trim(moment(value).format(format)) : value) || ''; | |||
There was a problem hiding this comment.
What if timezone is undefined and component is multiple? The line 207 is skipped and we go to line 211 that does not expect array value.
It also would be nice to separate repeated code in some new method. I mean lines 207 and 209. The same is for Time component.
There was a problem hiding this comment.
I don't think that the repeated code should be separated in that case, because it is specific for that particular function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ts with multiple value enabled inside of the DataTable
Link to Jira Ticket
https://formio.atlassian.net/browse/FIO-7184
Description
Previously, DateTime and Time components didn't have support for multiple values inside of getValueAsString methods, which caused an error when the value was formatted by moment library. Added a case to format each value one by one.
How has this PR been tested?
Tested locally
Checklist: