Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-7074/FIO-7379: Fixes some issues caused by Wizzard was not always… #5396

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

alexandraRamanenka
Copy link
Contributor

… setting _data to submission data

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-7074
https://formio.atlassian.net/browse/FIO-7379

Description

What changed?

Previously, formio.js ... This PR replaces this behavior by ...

Why have you chosen this solution?

Although there were many potential solutions such as ..., [my solution] was best because ...

Dependencies

This PR depends on the following PRs from other Form.io modules: ...

How has this PR been tested?

I added automated tests to cover [all/the following] cases, including ...

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@alexandraRamanenka alexandraRamanenka marked this pull request as draft November 6, 2023 14:10
@alexandraRamanenka alexandraRamanenka marked this pull request as ready for review November 8, 2023 12:09
@TanyaGashtold TanyaGashtold merged commit dedc49a into master Nov 16, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants