Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-7547: Container hidden with conditional logic still appears in submission #5401

Merged
merged 2 commits into from
Nov 14, 2023

Conversation

alexandraRamanenka
Copy link
Contributor

…bmission

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-7547

Description

What changed?

Previously, formio.js ... This PR replaces this behavior by ...

Why have you chosen this solution?

Although there were many potential solutions such as ..., [my solution] was best because ...

Dependencies

This PR depends on the following PRs from other Form.io modules: ...

How has this PR been tested?

An automated test was added

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@lane-formio lane-formio merged commit cf541c3 into master Nov 14, 2023
4 checks passed
lane-formio pushed a commit that referenced this pull request Nov 14, 2023
…bmission (#5401)

* FIO-7547: Container hidden with conditional logic still appears in submission

* Fixed tests
lane-formio pushed a commit that referenced this pull request Nov 22, 2023
…bmission (#5401)

* FIO-7547: Container hidden with conditional logic still appears in submission

* Fixed tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants