Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-4871: Fixed calculated value for data grid component #5448

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

roma-formio
Copy link
Contributor

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-4871

Description

When the DataGrid component has the default 1st row, we can find some fields already have empty values in JSON. This is a reason why the calculated value doesn't apply for DataGrid with allow override. I tried to change this logic and save DataGrid with an empty array without nested fields. As a result, it caused a lot of tests to fail and can be an issue with the compatibility of existing forms. So I changed the isEmpty method for DataGrid to skip default empty fields and apply calculated value.

How has this PR been tested?

Unit testing

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@TanyaGashtold TanyaGashtold merged commit 6269e94 into master Jan 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants