Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-7786: Fixing Datagrid issue in Settings JSON #5464

Merged
merged 1 commit into from
Jan 19, 2024
Merged

FIO-7786: Fixing Datagrid issue in Settings JSON #5464

merged 1 commit into from
Jan 19, 2024

Conversation

edwinanciani
Copy link
Contributor

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-7786

Description

What changed?

Added null flag conditional

Why have you chosen this solution?

NA

Breaking Changes / Backwards Compatibility

NA

Dependencies

NA

How has this PR been tested?

Manually

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

Copy link
Contributor

@brendanbond brendanbond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My question is why and how could this.components be undefined at this point? Is there something upstream we need to worry about?

@travist
Copy link
Member

travist commented Jan 19, 2024

👍

@travist travist merged commit b5feec9 into master Jan 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants