Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-7839: Fixing Sanitize before interpolate #5484

Closed
wants to merge 1 commit into from
Closed

Conversation

edwinanciani
Copy link
Contributor

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-7839

Description

What changed?

The content was being sanitized before interpolation causing template errors.

Why have you chosen this solution?

The implementation was correct but in wrong order.

Breaking Changes / Backwards Compatibility

Use this section to describe any potentially breaking changes this PR introduces or any effects this PR might have on backwards compatibility

Dependencies

None

How has this PR been tested?

Manually

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

Copy link
Contributor

@brendanbond brendanbond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a massive change for such a small benefit. It comes from this PR from about a month ago - isn't there a way we could simply rethink the way that URL in the developer portal is displayed to the user?

I worry about unintended consequences here, but I could be overthinking things.

@lane-formio
Copy link
Contributor

Re-evaluating our strategy here. Closing PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants