Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-7445: fixed an issue where the interpolated data does not show up… #5510

Merged

Conversation

KatrinKhilko
Copy link
Contributor

… on PDF

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-7445

Description

Previously HTML component and interpolation within was rendered before component got data from submission and was refreshed when checkData triggers, PDF generation process was started before refresh is finished. Now we make sure to setContent as soon as we get dynamic data ready.

Breaking Changes / Backwards Compatibility

n/a

Dependencies

n/a

How has this PR been tested?

tested locally

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@TanyaGashtold TanyaGashtold merged commit 75d7c45 into master Feb 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants