Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-7507: publish-dev-tag-to-npm #5543

Merged
merged 13 commits into from
Apr 29, 2024
Merged

Conversation

ryanformio
Copy link
Contributor

@ryanformio ryanformio commented Mar 20, 2024

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-7507

Description

What changed?

Necessary to complete task. Runs Build / Test / Publish on PR opened and synchronize.

Compare To:
https://www.npmjs.com/package/@formio/js/v/5.0.0-rc.27?activeTab=code

To Compare:
https://www.npmjs.com/package/@formio/js/v/5.0.0-dev.5543.eaae5a6?activeTab=code

Why have you chosen this solution?

Requires the dev to create a PR and will run build, tests, and publish for pipelines.

Dependencies

n/a

How has this PR been tested?

https://github.com/formio/formio.js/actions/runs/8392524012

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@ryanformio ryanformio marked this pull request as ready for review March 20, 2024 16:49
@ryanformio ryanformio marked this pull request as draft March 21, 2024 15:58
@ryanformio ryanformio marked this pull request as ready for review March 21, 2024 17:51
@ryanformio ryanformio marked this pull request as draft April 3, 2024 19:50
@ryanformio
Copy link
Contributor Author

ryanformio commented Apr 3, 2024

The publish package between dev and rc are inconsistent. Missing embed.d.ts, sdk.d.ts, and utils.d.ts
image


Update:

Looks like some changes still need to be brought in from https://formio.atlassian.net/browse/FIO-4112.

Compared to the 5.0.0-rc.27 and looks okay against that.
image

@ryanformio ryanformio marked this pull request as ready for review April 5, 2024 18:38
Copy link
Contributor

@brendanbond brendanbond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryanformio before I merge, did you get to the bottom of the issue with the *.d.ts files you referenced earlier?

@ryanformio
Copy link
Contributor Author

@ryanformio before I merge, did you get to the bottom of the issue with the *.d.ts files you referenced earlier?

Yeah discussed with Lane, I believe Travis has a PR relating to FIO-4112 that is where those files come from.
image

@brendanbond brendanbond merged commit 4238d13 into master Apr 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants