FIO-8141 Fixed error for nested forms in deployed in jsfiddle #5551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travist
requested changes
Apr 1, 2024
| @@ -90,7 +90,17 @@ export default class FormComponent extends Component { | |||
| if (!this.formSrc && this.options.formio) { | |||
| const rootSrc = this.options.formio.formsUrl; | |||
| if (this.component.form && isMongoId(this.component.form)) { | |||
| this.formSrc = `${rootSrc}/${this.component.form}`; | |||
| if ( | |||
There was a problem hiding this comment.
This change seems very specific and worries me that this is a band-aid for a problem that would be fixed elsewhere. Let's talk through this in Dev Support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Jira Ticket
https://formio.atlassian.net/browse/FIO-8141
Description
Previously, when loading a Nested Form component via jsfiddle, an incorrect request was sent to load the child form. As a result, error 400 occurred and the form was not displayed. This has been fixed by adding an additional check for the formSrc property
Dependencies
no
How has this PR been tested?
locally with using JSFiddle
Checklist: