Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: WizardBuilder removes page when saving other component with duplicate API key #5568

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

akgagnat
Copy link
Contributor

Link to Jira Ticket

N/A

Description

How to reproduce the bug:

  1. Go to formio sandbox
  2. Change form display to 'wizard'
  3. Insert a new component (e.g. Text Field) in page, provide same API key as the page and save
  4. Observe error 'API key is not unique'
  5. Edit component, provide a unique API key and save
  6. The page has now been removed (actually replaced by the component that was changed)

What is changed in this PR:

The lookup in WizardBuilder's saveComponent event handler is done based on id instead of key.

Dependencies

N/A

How has this PR been tested?

I added unit tests.

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant