Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update types to parent Form class; add builder options type #5585

Closed
wants to merge 3 commits into from

Conversation

brendanbond
Copy link
Contributor

@brendanbond brendanbond commented May 6, 2024

Link to Jira Ticket

n/a

Description

Moved Form types to parent Form component to be imported by Webform (and eventually PDFForm and Wizard). Also typed Builder options.

Dependencies

n/a

How has this PR been tested?

n/a

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@brendanbond
Copy link
Contributor Author

Closing in favor of the work we did in devex - https://github.com/formio/formio.js/tree/devex/jsdoc-migration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant