FIO-7195: Fixes an issue where Select, Radio and SelectBoxes components with URL DataSource show values instead of labels in modal preview #5586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts with URL DataSource show values instead of labels in modal preview
alexandraRamanenka
force-pushed
the
FIO-7195-select-radio-itl-url-source-show-value-for-modal-preview
branch
from
0ae6b17 to
75f460a
Compare
…lect-radio-itl-url-source-show-value-for-modal-preview
TanyaGashtold
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Jira Ticket
https://formio.atlassian.net/browse/FIO-7195
Description
The value for the modal preview is taken as a result of getValueAsString execution with modalPreview option passed, so I just added the missing part
Dependencies
This PR depends on the following PRs from other Form.io modules: ...
How has this PR been tested?
Mannually + automated tests were added
Checklist: