Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-8302 Fixed issue with wizard api key overriding window.property objects #5588

Merged
merged 3 commits into from
May 27, 2024

Conversation

ZenMasterJacob20011
Copy link
Contributor

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-8302

Description

The requireLibrary function in Formio.js now ignores any properties in the window object that are the type HTMLElement. Previously the window.property was unexpectedly being set by HTMLElements with an id attribute. This caused requireLibrary to pull in the HTMLElement instead of the expected object from <script src='...'>. A function was added to only get a window.property if it is not of the type HTMLElement

Dependencies

How has this PR been tested?

Manual testing

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@TanyaGashtold TanyaGashtold merged commit fd05635 into master May 27, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants