Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devex/jsdoc migration #5601

Merged
merged 76 commits into from
May 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
76 commits
Select commit Hold shift + click to select a range
fa7bf41
wip: add linting jsdoc etc
brendanbond Apr 19, 2024
eef5b02
merge master and fix conflicts
brendanbond Apr 25, 2024
a7039a2
replace esdoc with jsdoc
brendanbond Apr 25, 2024
06404e8
remove esdoc config file
brendanbond Apr 25, 2024
1d1efe4
lint a bunch of files and add lint yarn script
brendanbond Apr 25, 2024
b2bb269
Adding esdocs to src/Element.js
travist Apr 25, 2024
5cff9ad
jsdoc for Providers.js
Apr 25, 2024
167d9b9
update webform jsdoc types
brendanbond Apr 25, 2024
ace3ef0
minor
brendanbond Apr 25, 2024
b4777bf
fix linting errors
brendanbond Apr 25, 2024
b33f306
update types for nested component
brendanbond Apr 25, 2024
913986b
breadCrumbSettings -> breadcrumbSettings at line 142
ryanformio Apr 25, 2024
24e2e10
breadCrumbSettings -> breadcrumbSettings at line 142, resolve conflicts
ryanformio Apr 25, 2024
002fbc3
update formio.form.js jsdoc
brendanbond Apr 25, 2024
d099ec7
Merge branch 'devex/jsdoc-migration' of github.com:formio/formio.js i…
brendanbond Apr 25, 2024
e94e31e
Adding some jsdocs to src/components/_classes/component/Component.js
travist Apr 25, 2024
3f81d9b
jsdoc for address provider base class and azure address
Apr 25, 2024
24298a6
Merge branch 'devex/jsdoc-migration' of https://github.com/formio/for…
Apr 25, 2024
a158cb8
one warning left at line 16, did not want to alter constructor logic …
ryanformio Apr 25, 2024
942c165
Merge branch 'devex/jsdoc-migration' of github.com:formio/formio.js i…
ryanformio Apr 25, 2024
818de22
address provider jsdoc
May 2, 2024
b3e19b6
Adding component class docs.
travist May 2, 2024
b8d7303
Merge branch 'devex/jsdoc-migration' of github.com:formio/formio.js i…
travist May 2, 2024
8d515f8
Working on utils eslint.
travist May 2, 2024
308aa2a
WIP: update jsdoc
brendanbond May 3, 2024
2a36250
update types to parent Form class; add builder options type
brendanbond May 6, 2024
1b5b070
minor update
brendanbond May 7, 2024
3982848
merge conflicts
brendanbond May 9, 2024
2c840c4
Re-export methods from @formio/core for the utils functions.
travist Apr 23, 2024
fcaf8bd
Re-adding findComponents.
travist Apr 23, 2024
f45dbd4
Merge remote-tracking branch 'refs/remotes/origin/devex/jsdoc-migrati…
brendanbond May 9, 2024
3e0998c
JSDoc: Field.js
edwinanciani May 9, 2024
17ce188
update formbuilder options; type listcomponent and child classes
brendanbond May 9, 2024
85da5ab
Merge remote-tracking branch 'refs/remotes/origin/devex/jsdoc-migrati…
brendanbond May 9, 2024
b7cf90f
type definitions for file providers
May 9, 2024
1cc96c1
Merge branch 'devex/jsdoc-migration' of https://github.com/formio/for…
May 9, 2024
c83a783
resolve FormBuilder eslint warnings
brendanbond May 9, 2024
2dc946e
Merge remote-tracking branch 'refs/remotes/origin/devex/jsdoc-migrati…
brendanbond May 9, 2024
fd4b5e0
fix password strength linting warnings and fileProcessor lints
brendanbond May 9, 2024
3e6a8fa
whoopsie - minor typo
brendanbond May 9, 2024
ee5fe59
Updated utils docs.
travist May 9, 2024
6f7c968
Merge branch 'devex/jsdoc-migration' of github.com:formio/formio.js i…
travist May 9, 2024
ded3f65
cleaned up lint errors
May 9, 2024
f6bc550
Merge branch 'devex/jsdoc-migration' of https://github.com/formio/for…
May 9, 2024
6358b85
jsDoc added to Multvalue.js
ryanformio May 9, 2024
688c6b5
JSDoc-Update: NestedComponent.js
edwinanciani May 9, 2024
8530c59
fix linter warnings for Input, ListComponent, and Multivalue
brendanbond May 9, 2024
124fa12
fix merge conflicts
brendanbond May 9, 2024
51c69c0
lint fixes for Form, CalendarWidget, ListComponent.form.js
brendanbond May 16, 2024
5622ef9
jsdoc updates for Well.form and ListComponent.form
brendanbond May 16, 2024
3d5120d
updates to edit forms for list, time, unknown, url, and well
brendanbond May 16, 2024
f48befa
Adding types to utils.
travist May 16, 2024
83e85fe
jsdoc updates to textfield and textfield.form
brendanbond May 16, 2024
4f5bde9
Fixing typedocs on edit forms.
travist May 16, 2024
a3cd395
use generic edit form function definition
brendanbond May 16, 2024
ee500d9
Merge branch 'devex/jsdoc-migration' of github.com:formio/formio.js i…
travist May 16, 2024
e406d73
Merge branch 'devex/jsdoc-migration' of github.com:formio/formio.js i…
travist May 16, 2024
b4b6cee
jsdoc updates to Tabs and TextArea
brendanbond May 16, 2024
a21a907
Merge remote-tracking branch 'refs/remotes/origin/devex/jsdoc-migrati…
brendanbond May 16, 2024
3dc0ec3
jsdoc updates to SelectBoxes, Select, Number, Hidden
brendanbond May 16, 2024
b39cc90
Adding lint for Form.
travist May 16, 2024
032580a
jsdoc updates to day and editgrid
brendanbond May 16, 2024
a3d2bbc
jsdoc updates to DataGrid
brendanbond May 16, 2024
a7285e3
Fixing lint for pdf, wizard, and webform builder.
travist May 16, 2024
c6ccf8f
Merge remote-tracking branch 'refs/remotes/origin/devex/jsdoc-migrati…
brendanbond May 16, 2024
a336380
Merge remote-tracking branch 'refs/remotes/origin/devex/jsdoc-migrati…
brendanbond May 16, 2024
2553eb8
address through currency
Dmeeks512 May 16, 2024
9bad491
Adding docs to edit forms in _classes.
travist May 16, 2024
0f43e6f
Updated componments.
travist May 16, 2024
28b4d38
jsdoc updates to nested form
brendanbond May 16, 2024
7923c4c
Merge remote-tracking branch 'refs/remotes/origin/devex/jsdoc-migrati…
brendanbond May 16, 2024
d9a09b1
Merge remote-tracking branch 'refs/remotes/origin/devex/jsdoc-migrati…
Dmeeks512 May 16, 2024
060c2cc
Merge remote-tracking branch 'refs/remotes/origin/devex/jsdoc-migrati…
Dmeeks512 May 16, 2024
4b4e59f
fix merge conflicts
brendanbond May 16, 2024
725be6c
delete accidental addition
brendanbond May 16, 2024
5548477
update package json script and lockfile
brendanbond May 16, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions .esdoc.json

This file was deleted.

10 changes: 10 additions & 0 deletions .eslintignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
node_modules
lib
dist
app
test
types
*.spec.js
*.unit.js
_site
docs
17 changes: 17 additions & 0 deletions .eslintrc.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
module.exports = {
"env": {
"browser": true,
"es2021": true,
"node": true
},
"extends": ["eslint:recommended", "plugin:jsdoc/recommended-typescript-flavor"],
"parserOptions": {
"ecmaVersion": "latest",
"sourceType": "module"
},
"plugins": ["jsdoc"],
"rules": {
"no-prototype-builtins": "off",
"no-unused-vars": ["error", { "argsIgnorePattern": "^_" }],
}
}
38 changes: 0 additions & 38 deletions .eslintrc.json

This file was deleted.

9 changes: 0 additions & 9 deletions gulpfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ const concat = require('gulp-concat');
const replace = require('gulp-replace');
const rename = require('gulp-rename');
const cleanCSS = require('gulp-clean-css');
const eslint = require('gulp-eslint');
const clean = require('gulp-clean');

// Clean lib folder.
Expand All @@ -18,14 +17,6 @@ gulp.task('clean:lib', () => {
});
gulp.task('clean', gulp.parallel('clean:dist', 'clean:lib'));

// ESLint
gulp.task('eslint', function eslintTask() {
return gulp.src(['./src/**/*.js', '!./src/**/*.spec.js'])
.pipe(eslint())
.pipe(eslint.format())
.pipe(eslint.failAfterError());
});

// Move font-awesome fonts into dist folder.
gulp.task('builder-fonts', function builderFonts() {
return gulp.src('./node_modules/bootstrap-icons/font/fonts/*').pipe(gulp.dest('dist/fonts'));
Expand Down
11 changes: 4 additions & 7 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
],
"scripts": {
"build": "yarn doc && yarn lib && yarn dist",
"doc": "esdoc",
"doc": "typedoc",
"dist": "gulp clean:dist && webpack --config webpack.config.js && webpack --config webpack.prod.js && gulp build",
"lib": "gulp clean:lib && tsc --project tsconfig.cjs.json && tsc --project tsconfig.mjs.json && yarn lib:package",
"lib:package": "node ./libpackage.js",
Expand All @@ -50,7 +50,7 @@
"release": "yarn build-app && yarn deploy-s3",
"tag": "VERSION=$(yarn version);git add -A; git commit -m \"Build $Version\";git push origin master;git tag v$VERSION;git push origin --tags;",
"dopublish": "npm run build && npm run tag && npm publish",
"lint": "gulp eslint",
"lint": "eslint ./src --fix",
"serve": "jekyll serve --config _config.yml,_config.dev.yml",
"test": "mocha 'src/**/*.unit.js'",
"test:updateRenders": "npm run lib && TZ=UTC node --require jsdom-global/register test/updateRenders.js",
Expand Down Expand Up @@ -124,11 +124,8 @@
"chance": "^1.1.9",
"ejs-loader": "^0.5.0",
"escape-string-regexp": "^5.0.0",
"esdoc": "^1.1.0",
"esdoc-ecmascript-proposal-plugin": "^1.0.0",
"esdoc-standard-plugin": "^1.0.0",
"eslint": "^8.57.0",
"eslint-config-formio": "^1.1.4",
"eslint-plugin-jsdoc": "^48.2.3",
"fetch-mock": "^9.11.0",
"file-loader": "^6.2.0",
"flatpickr": "^4.6.13",
Expand All @@ -137,7 +134,6 @@
"gulp-clean": "^0.4.0",
"gulp-clean-css": "^4.3.0",
"gulp-concat": "^2.6.1",
"gulp-eslint": "^6.0.0",
"gulp-filter": "^7.0.0",
"gulp-rename": "^2.0.0",
"gulp-replace": "^1.1.3",
Expand Down Expand Up @@ -168,6 +164,7 @@
"ts-loader": "^9.4.4",
"ts-node": "^10.9.1",
"tsc": "^2.0.4",
"typedoc": "^0.25.13",
"typescript": "5.3.2",
"webpack": "^5.90.3",
"webpack-bundle-analyzer": "^4.10.2",
Expand Down
Loading
Loading