Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-8359: Event No Longer Emitted on Submit #5608

Closed

Conversation

ryanformio
Copy link
Contributor

@ryanformio ryanformio commented May 20, 2024

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-8359

Description

What changed?

Previously formio.js was not emitting the error event on form submit.

Why have you chosen this solution?

Resolve error event emit

Dependencies

n/a

How has this PR been tested?

1. Check out 4.19.x branch in `formio.js`
2. yarn install && yarn build
3. change into the dist directory.
4. Use a simple http server to host files as if they were a local cdn `http-server -p 4003 --cors`
5. Set up a simple playground that listens for an error event to be emitted. (SEE ATTACHMENTS cdn.zip on this ticket)
6. Unzip cdn.zip and npm install && npm start
7. Submit form and view console.log statements.

Expected should see "Hello, World!" in console because the error event was emitted triggering this log message.

Actual result, do not see the message printed to console. Reverting line 1343 on https://github.com/formio/formio.js/pull/5101/files resolves this issue.

image

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@ryanformio ryanformio marked this pull request as ready for review May 20, 2024 15:25
@ryanformio ryanformio changed the base branch from 4.19.x to master May 21, 2024 14:25
@ryanformio ryanformio changed the base branch from master to 4.19.x May 21, 2024 14:26
@lane-formio
Copy link
Contributor

Resolved with #5472 in master branch. We'll cherry-pick that over if we decide we need it for 4.19.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants