Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-7854: revert memory leak backport #5614

Closed
wants to merge 5 commits into from

Conversation

brendanbond
Copy link
Contributor

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-7854

Description

This PR reverts the 'm' branch (orphaned original 5.x rewrite of the renderer) memory leak backports, because they were causing some problems.

Dependencies

n/a

How has this PR been tested?

n/a

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

This reverts commit 3b0539f.

remove i18next dep from webform

another merge conflict error

Revert one small change
@travist
Copy link
Member

travist commented Aug 15, 2024

I don't want to pull in this revert. From the memory leak PR, there was an issue identified with the PDF builder, and this was resolved with this PR #5729. You will notice that change is part of the revert, but for the most part, MOST of these changes we DO want. My preference is to tackle each issue independently instead of reverting a big change that did make some memory leak improvements.

@travist travist closed this Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants