Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-8234: Fixes an issue where Select with Resource data source renders values instead of labels in the read only mode #5620

Merged

Conversation

alexandraRamanenka
Copy link
Contributor

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-8234

Description

In the read only mode we are not fetching data from remote sources like URL and resource, so the Select components renders value, so I made use saved select metadata to render the labels properly
Why have you chosen this solution?

Although there were many potential solutions such as ..., [my solution] was best because ...

Dependencies

This PR depends on the following PRs from other Form.io modules: ...

How has this PR been tested?

I added automated tests to cover [all/the following] cases, including ...

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

…rs values instead of labels in the read only mode
@TanyaGashtold TanyaGashtold merged commit e4e42ba into master May 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants