Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-8402: fixed an issue where Validation Triggering on initial Form load #5625

Merged

Conversation

KatrinKhilko
Copy link
Contributor

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-8402

Description

What changed?

The issue was caused by calculated values, form load use onChange method that performs calculation and set pristine flag to false even if form wasn't initialized and user hasn't made any changes. Choose adding check for form initialization.

Dependencies

n/a

How has this PR been tested?

Tested manually, all unit/integration tests pass locally

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@@ -2975,7 +2975,7 @@ export default class Component extends Element {
this.calculatedValue = fastCloneDeep(calculatedValue);

if (changed) {
if (!flags.noPristineChangeOnModified) {
if (!flags.noPristineChangeOnModified && this.root.initialized) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why can't we write tests for this? Even though it's a relatively simple change, a test or two would define the expected behavior of our program for developers and prevent regressions. It's also a good opportunity to test your assumptions to make sure there are no edge cases that haven't been considered.

@lane-formio lane-formio merged commit 3ceace6 into master Jun 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants