Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-8395: html in error message not evaluating #5632

Merged
merged 5 commits into from
Jun 11, 2024

Conversation

ZenMasterJacob20011
Copy link
Contributor

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-8395

Description

What changed?

Previously, formio.js would remove the html tags from error messages. This PR replaces this behavior by removing the code that causes the removal of the html tags. This PR also updates the unescapeHTML function in utils to stop removing the html tags from the string. This PR also adds a new removeHTML function that removes html from a string. I added this to replace areas of the code that used unescapeHTML because the actual functionality that is needed is to remove html not unescape characters.

Why have you chosen this solution?

I choose this solution because it allows for other areas of the code to now utilize unescapeHTML without the unexpected behavior of removing html tags.

Dependencies

N/A

How has this PR been tested?

Manually tested and added tests

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@TanyaGashtold TanyaGashtold merged commit cc68bdf into master Jun 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants