Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding JSDocs and fixes for the 5x Renderer Version. #5641

Merged
merged 13 commits into from
Jun 18, 2024
Merged

Conversation

travist
Copy link
Member

@travist travist commented Jun 9, 2024

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-XXXX

Description

What changed?

Previously, formio.js ... This PR replaces this behavior by ...

Why have you chosen this solution?

Although there were many potential solutions such as ..., [my solution] was best because ...

Dependencies

This PR depends on the following PRs from other Form.io modules: ...

How has this PR been tested?

I added automated tests to cover [all/the following] cases, including ...

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

package.json Outdated Show resolved Hide resolved
@brendanbond brendanbond merged commit 0b97298 into master Jun 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants