Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-8496: added loading=async for Google Maps JavaScript API #5651

Conversation

KatrinKhilko
Copy link
Contributor

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-8496

Description

Added loading=async to Google Maps JavaScript API src to prevent console warning.

Dependencies

n/a

How has this PR been tested?

Tested manually

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@johnformio
Copy link
Contributor

@KatrinKhilko I approved, but it has merge conflicts.

@johnformio
Copy link
Contributor

@KatrinKhilko You have merge conflicts

@johnformio johnformio merged commit 0d0f421 into master Jun 20, 2024
5 checks passed
@johnformio johnformio deleted the FIO-8496-Google-Maps-JavaScript-API-has-been-loaded-directly-without-loading=async branch June 20, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants