Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-8445: Fixed searchbar not focusing when navigating using up and down arrows #5654

Merged

Conversation

ZenMasterJacob20011
Copy link
Contributor

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-8445

Description

What changed?

Previously, formio.js would unfocus the search bar when navigating the select component with the up and down keyboard arrows. This PR replaces this behavior by modifying the selectHighlightedChoice function to use the addItem choicesjs function instead of the handleChoiceAction choicesjs function. This allows the selectHighlightedChoices function to behave more like a highlighting choices instead of selecting choices when navigating using arrow keys.

Why have you chosen this solution?

*Although there were many potential solutions my solution was best because it introduces no new errors or bugs

Dependencies

N/A

How has this PR been tested?

manual testing

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@brendanbond brendanbond merged commit 87581ad into master Jun 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants