Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-7936: showCounter messages not translating #5655

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

ZenMasterJacob20011
Copy link
Contributor

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-7936

Description

What changed?

Previously, formio.js did not translate the counter message when you had showCharCount and showWordCount enabled. This PR replaces this behavior by adding a translations for showCharCount and showWordCount.

Why have you chosen this solution?

This allows for users to override the the translation by adding the typeRemaining and typeCount to the i18n options.

Dependencies

N/A

How has this PR been tested?

I added automated tests to test translation and manually tested

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@brendanbond brendanbond merged commit 342578e into master Jun 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants