Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-8072: Added conditional operators for select component with number data type #5656

Merged

Conversation

roma-formio
Copy link
Contributor

@roma-formio roma-formio commented Jun 21, 2024

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-8072

Description

Feature: Enhancements to the 'Select' component - Expanded operator options for simple conditionals with number type.

Solution: The solution maintains backward compatibility and is designed for easy extensibility. This is achieved by specifying additional properties in the conditionOperatorsSettings getter, which are related to the type. This approach allows us to easily manage available operators and modify the value component type. Further control over the operator and value component will be managed by the premium library. No specific handling is required for new operators as they function as expected.

How has this PR been tested?

Unit Tests: Unit tests have been conducted to verify conditional rendering based on the number operator.

Integration Testing: The commit has been cherry-picked to the 4.19x branch and linked to the formio-app and premium for integration testing, confirming the feature works as expected.

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@HannaKurban HannaKurban merged commit f23f18f into master Aug 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants