Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-7775: reset value event resets component values to their default values #5661

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

ZenMasterJacob20011
Copy link
Contributor

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-7775

Description

Previously, formio.js reset value event would reset all components values to an empty value. This PR replaces this behavior by setting the value to the components default value, else if the component does not have a default value fall back to the empty value.

Why have you chosen this solution?

Although there were many potential solutions my solution was best because it allows all components to reset their values to the default value and will fallback to empty value if the component has no default value

Dependencies

N/A

How has this PR been tested?

I added automated tests and manually tested

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@brendanbond brendanbond merged commit f968a87 into master Jun 26, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants