Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-8461: Fixes checkbox with radio input type not present in submission on 5.x renderer #5670

Conversation

mikekotikov
Copy link
Contributor

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-8461

Description

What changed?

Previously, Checkbox with input type 'radio' and key + value set wasn't present in submission if left empty. This PR fixes this behavior by making specified key be present in submission.

Why have you chosen this solution?

I've made it to work same way as if you check -> uncheck the checkbox. In this case it was set to the submission object with empty string value ("").

Dependencies

None

How has this PR been tested?

I added automated test to cover the buggy case

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@mikekotikov mikekotikov changed the title Fix/fio 8461 5x fix checkbox with radio input type submission issue FIO-8461: Fixes checkbox with radio input type not present in submission on 5.x renderer Jul 2, 2024
@brendanbond brendanbond merged commit f2a9ce6 into master Jul 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants