FIO-8270: panel component closing on logic event trigger #5676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…original component
johnformio
reviewed
Jul 11, 2024
Comment on lines
+401
to
+409
| setTimeout(()=>{ | ||
| textFieldComponent.refs.input[0].value = "test" | ||
| textFieldComponent.refs.input[0].dispatchEvent(new Event('input')); | ||
| setTimeout(()=>{ | ||
| assert.equal(panelComponent.component.hidden, false); | ||
| assert.equal(panelComponent.visible, true); | ||
| done(); | ||
| },400); | ||
| },200); |
There was a problem hiding this comment.
I'm not fond of this pattern. We should discuss a better pattern for these.
There was a problem hiding this comment.
Is it that we have two sources of truth to check if a component is visible or not?
johnformio
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Jira Ticket
https://formio.atlassian.net/browse/FIO-8270
Description
What changed?
Previously, formio.js would revert back to the original component schema if a logic event action changed the hidden state of the component and any component triggered its change event. This PR replaces this behavior by allowing logic event listeners to update the original component hidden property so that it does not get reverted back when an input is made on the form.
Why have you chosen this solution?
Although there were many potential solutions, my solution was best because it allows all the tests to pass
Dependencies
N/A
How has this PR been tested?
I added automated tests and manually tested
Checklist: