Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: allow paths for valueProperty #5696

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

brendanbond
Copy link
Contributor

@brendanbond brendanbond commented Jul 17, 2024

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-8714

Description

Debugged an issue on a customer call where they couldn't use paths as valueProperties (e.g. pointing a Select Boxes component at a Form.io Resource URL and having a valueProperty of data.firstName). This PR works but needs to be evaluated for thoroughness and tested.

Dependencies

n/a

How has this PR been tested?

Automated tests

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@brendanbond brendanbond changed the base branch from 4.20.x to master July 17, 2024 11:56
@brendanbond brendanbond marked this pull request as ready for review August 6, 2024 19:58
@brendanbond brendanbond merged commit 8fb772f into master Aug 6, 2024
5 checks passed
lane-formio pushed a commit that referenced this pull request Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants