Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-8647,8721: validation not triggered for each row after the first one in data and edit grid #5711

Conversation

KatrinKhilko
Copy link
Contributor

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-8647
https://formio.atlassian.net/browse/FIO-8721

Description

Error messages for different rows are the same so they was deleted by _.uniqBy, this pr changes function so it considers not only message but path and id.

Dependencies

n/a

How has this PR been tested?

Added test.

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

…h row after the first one in data and edit grid
@TanyaGashtold TanyaGashtold merged commit ca664e5 into master Jul 31, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants