FIO-8759 fixed validation for the default value component #5718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TanyaGashtold
approved these changes
Aug 7, 2024
TanyaGashtold
requested changes
Aug 7, 2024
src/WebformBuilder.js
Outdated
| @@ -1237,6 +1237,7 @@ export default class WebformBuilder extends Component { | |||
| _.pull(newComp.validators, 'required'); | |||
| parentComponent.tabs[tabIndex].splice(index, 1, newComp); | |||
| newComp.checkValidity = () => true; | |||
| newComp.checkComponentValidity = () => true; | |||
There was a problem hiding this comment.
Why do not we just add the required day property to the properties list that must be omitted for the default value field (line 1200)?
TanyaGashtold
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Jira Ticket
https://formio.atlassian.net/browse/FIO-8759
Description
Fixed a behavior where it was not possible to add Day component with required field add to the form due to the validation of default value Field
Breaking Changes / Backwards Compatibility
n/a
Dependencies
n/a
How has this PR been tested?
automated tests have been added. all tests pass locally
Checklist: