Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-8627: Fixed the email table generation for nested array components #5719

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

roma-formio
Copy link
Contributor

@roma-formio roma-formio commented Jul 30, 2024

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-8627

Description

Issue: When a layout component is included in the edit grid and input components are added inside the layout component, the table is generated without considering the layout component. As a result, all nested components are skipped, leading to an empty grid.

Solution: Add a check to determine if the component is a layout component and iterate through all possible nested components using the everyComponent method.

How has this PR been tested?

Unit tests

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@TanyaGashtold TanyaGashtold merged commit 96fec48 into master Aug 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants