Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-8706: allow data interpolation for data source in components #5720

Conversation

ZenMasterJacob20011
Copy link
Contributor

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-8706

Description

What changed?

Added the myApiUrl property to the form object so that it can be used in interpolation

Breaking Changes / Backwards Compatibility

N/A

Dependencies

N/A

How has this PR been tested?

manually tested and automated test

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

Copy link
Contributor

@brendanbond brendanbond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the thrust of this ticket has been misunderstood. Let's discuss in dev support please

Copy link
Contributor Author

@ZenMasterJacob20011 ZenMasterJacob20011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Committed new changes

@ZenMasterJacob20011
Copy link
Contributor Author

Switched sanitize and interpolate order

@brendanbond brendanbond merged commit 62adfa5 into master Aug 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants