Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: fix runtime error in setForm when passing string argument to Formio.builder #5732

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

brendanbond
Copy link
Contributor

@brendanbond brendanbond commented Aug 8, 2024

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-8809

Description

setUrl is a Webform method, so it won't exist when rendering a builder with a string form argument (e.g. Formio.builder(element, 'https://examples.form.io/example'); and will result in a runtime error.

Breaking Changes / Backwards Compatibility

n/a

Dependencies

n/a

How has this PR been tested?

n/a

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@brendanbond brendanbond changed the title WebformBuilder e.g. does not contain a setUrl method, so check for it… Bugfix: fix runtime error in setForm when passing string argument to Formio.builder Aug 8, 2024
@TanyaGashtold TanyaGashtold merged commit 238b5a5 into master Aug 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants